+
Skip to content

Conversation

sur5r
Copy link
Contributor

@sur5r sur5r commented May 26, 2023

Fixes #37.

It's the approach from #106 but using Qt only.

10 ms was still racy in my tests (writing STL from OpenSCAD), so I went with 100 ms.

Fixes fstl-app#37.

It's the approach from fstl-app#106 but using Qt only.
@DeveloperPaul123
Copy link
Member

If you could retest from master and see if 10 ms is still racy for you, I'm happy to accept a PR that adjusts the time. Or maybe we can make it configurable

@sur5r
Copy link
Contributor Author

sur5r commented May 26, 2023

If you could retest from master and see if 10 ms is still racy for you, I'm happy to accept a PR that adjusts the time. Or maybe we can make it configurable

That was not the main point of this PR. My focus was on using Qt only, not going to POSIX/plain STL, and having less code for the same functionality.

@DeveloperPaul123
Copy link
Member

DeveloperPaul123 commented May 26, 2023

Ok my mistake. I misunderstood the goal of the PR. I'll give this a test and see if we can merge it in still

@DeveloperPaul123
Copy link
Member

@gsohler Would you be willing to test this PR out and see if it solves #37 for you as well?
I think I prefer the Qt approach for fstl in this case

Use the fully qualified static function to make it clear that it is coming from Qt and not POSIX
@gsohler
Copy link
Contributor

gsohler commented May 26, 2023 via email

@DeveloperPaul123
Copy link
Member

#37 is closed already , suppose the answer was yes

On Fri, May 26, 2023 at 6:34 PM Paul T @.> wrote: @gsohler https://github.com/gsohler Would you be willing to test this PR out and see if it solves #37 <#37> for you as well? I think I prefer the Qt approach for fstl in this case — Reply to this email directly, view it on GitHub <#107 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCO4MV6J7BVJJDZCQBHP6TXIDLRPANCNFSM6AAAAAAYP7GDGQ . You are receiving this because you were mentioned.Message ID: @.>

I closed that due to your PR. This PR addresses the same issue but in a different way and does not include the changes you made. In retrospect I think I prefer the Qt-centric approach to solve the issue.

@gsohler
Copy link
Contributor

gsohler commented May 26, 2023 via email

@DeveloperPaul123
Copy link
Member

i am fine with that. i am happy, that my proposed algorithm is still inside.

On Fri, May 26, 2023 at 9:07 PM Paul T @.> wrote: #37 <#37> is closed already , suppose the answer was yes … <#m_8963716526631296567_> On Fri, May 26, 2023 at 6:34 PM Paul T @.> wrote: @gsohler https://github.com/gsohler https://github.com/gsohler https://github.com/gsohler Would you be willing to test this PR out and see if it solves #37 <#37> <#37 <#37>> for you as well? I think I prefer the Qt approach for fstl in this case — Reply to this email directly, view it on GitHub <#107 (comment) <#107 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCO4MV6J7BVJJDZCQBHP6TXIDLRPANCNFSM6AAAAAAYP7GDGQ https://github.com/notifications/unsubscribe-auth/ACCO4MV6J7BVJJDZCQBHP6TXIDLRPANCNFSM6AAAAAAYP7GDGQ . You are receiving this because you were mentioned.Message ID: @.> I closed that due to your PR. This PR addresses the same issue but in a different way and does not include the changes you made. In retrospect I think I prefer the Qt-centric approach to solve the issue. — Reply to this email directly, view it on GitHub <#107 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCO4MVI6T4CFENQRN4S3OTXID5PXANCNFSM6AAAAAAYP7GDGQ . You are receiving this because you were mentioned.Message ID: @.**>

Thanks for being flexible

@DeveloperPaul123 DeveloperPaul123 merged commit 9e41de1 into fstl-app:master May 31, 2023
DeveloperPaul123 added a commit that referenced this pull request May 31, 2023
…more (#106)" (#109)

This reverts commit c4dd685.

# Conflicts:
#	src/window.cpp

With #107 merged, we no longer need the duplicated code in `window.cpp` as that logic was essentially moved to `loader.cpp` in #107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Corrupted stl with libfivepy

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载