[Debg] fix parsing from XML; add roundtrip tests #3781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note, neither the API nor the binary serialization have changed, only the xml serialization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3779
note this changes the ttx dump of 'Debg' table in that it wraps the CDATA block inside a
<json>sub-element, which is required for the XMLReader to be able to parse it back from TTX.Since parsing was silently broken until now, we shouldn't worry about backward compatibility but treat this as a bug fix.
It's also a private table which shouldn't be in production fonts so we are probably free to change as needed.