From 839bd0999e749565ddff852134674cd0d2500111 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 19 Aug 2025 15:08:02 -0700 Subject: [PATCH 1/4] Make the test explicitly fail --- packages/devtools_app/benchmark/devtools_benchmarks_test.dart | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/devtools_app/benchmark/devtools_benchmarks_test.dart b/packages/devtools_app/benchmark/devtools_benchmarks_test.dart index 60819df5198..ee33d15d99f 100644 --- a/packages/devtools_app/benchmark/devtools_benchmarks_test.dart +++ b/packages/devtools_app/benchmark/devtools_benchmarks_test.dart @@ -67,6 +67,9 @@ Future _runBenchmarks({bool useWasm = false}) async { ); stdout.writeln('Web benchmark tests finished.'); + // This should fail. + expect(2+2, equals(5)); + expect( const JsonEncoder.withIndent(' ').convert(taskResult.toJson()), isA(), From 9831659ddec3421b4f1c97bda9dec681dddfacb0 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 19 Aug 2025 15:31:02 -0700 Subject: [PATCH 2/4] Change where we set fast-fail option --- tool/ci/benchmark_performance.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tool/ci/benchmark_performance.sh b/tool/ci/benchmark_performance.sh index 8bde95a478a..a2301c8c900 100755 --- a/tool/ci/benchmark_performance.sh +++ b/tool/ci/benchmark_performance.sh @@ -4,11 +4,11 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd. +source ./tool/ci/setup.sh + # Fast fail the script on failures. set -ex -source ./tool/ci/setup.sh - pushd $DEVTOOLS_DIR/packages/devtools_app flutter test -j, --concurrency=1 benchmark/devtools_benchmarks_test.dart popd From a40abf7367db5c286755264f5ba0a8a6dca2fa95 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Mon, 15 Sep 2025 10:34:22 -0700 Subject: [PATCH 3/4] Make benchmarks unrealistic --- .../devtools_app/benchmark/devtools_benchmarks_test.dart | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/devtools_app/benchmark/devtools_benchmarks_test.dart b/packages/devtools_app/benchmark/devtools_benchmarks_test.dart index ee33d15d99f..6a92121ad9b 100644 --- a/packages/devtools_app/benchmark/devtools_benchmarks_test.dart +++ b/packages/devtools_app/benchmark/devtools_benchmarks_test.dart @@ -67,9 +67,6 @@ Future _runBenchmarks({bool useWasm = false}) async { ); stdout.writeln('Web benchmark tests finished.'); - // This should fail. - expect(2+2, equals(5)); - expect( const JsonEncoder.withIndent(' ').convert(taskResult.toJson()), isA(), @@ -179,7 +176,7 @@ void _verifyScoresAgainstThresholds( } } -const _frameTimeFor60FPSInMicros = 16666.6; +const _frameTimeFor60FPSInMicros = 16666.6 / 4; // const _frameTimeFor30FPSInMicros = 33333.3; /// Creates the expected [DevToolsBenchmark]s for the specified compiler. From 427e19dbb71a875f9553735890b5746976662fa4 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 14 Oct 2025 13:32:17 -0700 Subject: [PATCH 4/4] Remove unused argument --- .../devtools_app/benchmark/devtools_benchmarks_test.dart | 2 +- tool/ci/benchmark_performance.sh | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/devtools_app/benchmark/devtools_benchmarks_test.dart b/packages/devtools_app/benchmark/devtools_benchmarks_test.dart index 6a92121ad9b..60819df5198 100644 --- a/packages/devtools_app/benchmark/devtools_benchmarks_test.dart +++ b/packages/devtools_app/benchmark/devtools_benchmarks_test.dart @@ -176,7 +176,7 @@ void _verifyScoresAgainstThresholds( } } -const _frameTimeFor60FPSInMicros = 16666.6 / 4; +const _frameTimeFor60FPSInMicros = 16666.6; // const _frameTimeFor30FPSInMicros = 33333.3; /// Creates the expected [DevToolsBenchmark]s for the specified compiler. diff --git a/tool/ci/benchmark_performance.sh b/tool/ci/benchmark_performance.sh index a2301c8c900..4a5b246ed21 100755 --- a/tool/ci/benchmark_performance.sh +++ b/tool/ci/benchmark_performance.sh @@ -4,11 +4,11 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd. -source ./tool/ci/setup.sh - # Fast fail the script on failures. set -ex +source ./tool/ci/setup.sh + pushd $DEVTOOLS_DIR/packages/devtools_app -flutter test -j, --concurrency=1 benchmark/devtools_benchmarks_test.dart +flutter test --concurrency=1 benchmark/devtools_benchmarks_test.dart popd