+
Skip to content

Implemented tooltip for timeline #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thewolfwillcome
Copy link
Contributor

Implemented tooltip for timeline ad requested in feature request #165

Moved time formating into helper class
@flaviotordini
Copy link
Owner

Thanks! Why the tooltip when we can show the time on the toolbar time label? The logic in SeekSlider is not needed anymore? It was needed for one-click direct jump to a certain position. I'll test this out.

@thewolfwillcome
Copy link
Contributor Author

thewolfwillcome commented Jan 12, 2021

The tooltip shows the time under the cursor to which the video would jump when the user clicks on the slider.
That is what #165 requested.

PS:
The shown time in the tooltip and the real time to which the video jumps can differ because the length of the slider and the video duration doesn't match always. So the tooltip shows only a rough estimate to which a jump would occure when the video duration is very long but the slider is short

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载