Add a controller for channels view-model. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed you committed your API key inside minitube.pro. Remove it ASAP! |
|
Thanks, that was negligent =( |
|
This is needed to solve #5. I think ChannelView should not be aware of ChannelController at all. It should just emit signals and use an arbitrary model. |
- Add channelcontroller.{h,cpp} files.
- Use new controller class.
4e01a29 to
9a74075
Compare
9a74075 to
4b9c85d
Compare
|
Sorry for such a long delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Flavio.
Right now this request is not a candidate for merging.
I just wanted to discuss a way to extract data access logic from views like ChannelView.
IMHO, accessing database directly from view isn't a good pattern.
That's why I tried to move that part of code to a new class, ChannelController.
After this step it is possible to move database specific code to a distinct class and hide all SQL related things even from the controller.
What do you think about that?
(It seems that files channelsview.{h,cpp} are outdated and I removed it in this request.)