-
Notifications
You must be signed in to change notification settings - Fork 0
ADX-924 ADX-919 regression tests #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good step forward. Just flagged a few issues for attention. Thanks so much for moving on this quickly.
Co-authored-by: Jonathan Berry <jonathan.s.berry@gmail.com>
Co-authored-by: Jonathan Berry <jonathan.s.berry@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right back at you!
Co-authored-by: Jonathan Berry <jonathan.s.berry@gmail.com>
Agreed! |
So I have refactored #16 slightly and also added a test suite for this bug:
TestResourceCreate.test_not_fork_resource_create()
TestResourceUpdate.test_fork_resource_update_with_new_non_fork_resource_details()
TestResourceUpdate.test_non_fork_resource_update_with_new_fork_details()
TestResourceUpdate:test_fork_resource_update_with_activity_id()
TestResourceUpdate: test_fork_resource_update_with_new_metadata()
TestResourceUpdate.test_non_fork_resource_update_with_new_fork_details_via_api_call()
Also:
resource_update
etc., which under the hood callspackage_update
etc. - this could be a preference thing but it just felt weird to have classes that said they were testing package actions but that never called package actions directlyfork
to four pre-existing test names for consistency with new tests