+
Skip to content

Feature/Label-Addition initial commit #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2022

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

This PR apply changes that are a result of the upstream modifications within the source package. The addition of the label table, and depreciation of the label field within the issue_label table resulted in a number of updates needing to be applied. In particular, the creation of the int_github__issue_label_join model is the main update to account for these upstream changes.

Additionally, this PR fixes some out of date procedures. For example, references to staging models has been changed to vars for a more dynamic use of the package.

Finally, I noticed the int_github__issue_comment model was using the stg_github__issue_label model to generate the total count of comments. This is not accurate and has been adjusted to reference the stg_github__issue_comment model.

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide explanation how the change is non breaking below.)

Due to the upstream changes, this will result in a breaking change.

Is this PR in response to a previously created Issue

How did you test the PR changes?

  • CircleCi
  • Other (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🏷️

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review February 11, 2022 20:45
Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good -- also just wanna change the package version in the README installation instructions since this is breaking

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 500c022 into main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载