-
Notifications
You must be signed in to change notification settings - Fork 24
Add disabling variables for issue_assignee
, issue_label
, label
, and requested_reviewer_history
#64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9ff05ae
working
fivetran-jamie 0a23b4a
tests
fivetran-jamie 21d949d
tweaks
fivetran-jamie dc60ff2
docs
fivetran-jamie 66b9759
joe feedback
fivetran-jamie 0108885
avinash feedback
fivetran-jamie ee6eeca
switch source package dep
fivetran-jamie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 29 additions & 23 deletions
52
.github/PULL_REQUEST_TEMPLATE/maintainer_pull_request_template.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,35 @@ | ||
## PR Overview | ||
**This PR will address the following Issue/Feature:** | ||
<!-- | ||
Pre-Submission Reminders | ||
Before marking this PR as "ready for review": | ||
|
||
**This PR will result in the following new package version:** | ||
<!--- Please add details around your decision for breaking vs non-breaking version upgrade. If this is a breaking change, were backwards-compatible options explored? --> | ||
- `dbt run --full-refresh && dbt test` | ||
- `dbt run` && `dbt test` (if incremental models are present) | ||
- The related issue is linked, tagged, and appropriately assigned | ||
- Documentation and version updates are included, if applicable | ||
- `docs` have been regenerated (unless there are no code or YAML changes) | ||
- BuildKite integration tests are passing | ||
--> | ||
|
||
**Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:** | ||
<!--- Copy/paste the CHANGELOG for this version below. --> | ||
## PR Overview | ||
**Package version introduced in this PR:** | ||
|
||
**This PR addresses the following Issue/Feature(s):** | ||
<!-- Add Issue # or internal ticket reference --> | ||
|
||
## PR Checklist | ||
### Basic Validation | ||
Please acknowledge that you have successfully performed the following commands locally: | ||
- [ ] dbt run –full-refresh && dbt test | ||
- [ ] dbt run (if incremental models are present) && dbt test | ||
**Summary of changes:** | ||
<!-- 1-2 sentences describing PR changes. --> | ||
|
||
Before marking this PR as "ready for review" the following have been applied: | ||
- [ ] The appropriate issue has been linked, tagged, and properly assigned | ||
- [ ] All necessary documentation and version upgrades have been applied | ||
- [ ] docs were regenerated (unless this PR does not include any code or yml updates) | ||
- [ ] BuildKite integration tests are passing | ||
- [ ] Detailed validation steps have been provided below | ||
|
||
### Detailed Validation | ||
Please share any and all of your validation steps: | ||
<!--- Provide the steps you took to validate your changes below. --> | ||
### Submission Checklist | ||
- [ ] Alignment meeting with the reviewer (if needed) | ||
- [ ] Timeline and validation requirements discussed | ||
- [ ] Provide validation details: | ||
- [ ] **Validation Steps:** Check for unintentional effects (e.g., add/run consistency & integrity tests) | ||
- [ ] **Testing Instructions:** Confirm the change addresses the issue(s) | ||
- [ ] **Focus Areas:** Complex logic or queries that need extra attention | ||
|
||
### If you had to summarize this PR in an emoji, which would it be? | ||
<!--- For a complete list of markdown compatible emojis check our this git repo (https://gist.github.com/rxaviers/7360908) --> | ||
:dancer: | ||
### Changelog | ||
<!-- Recommend drafting changelog notes, then refining via ChatGPT using: | ||
"Draft a changelog entry based on the following notes." --> | ||
- [ ] Draft changelog for PR | ||
- [ ] Final changelog for release review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
{{ config( | ||
tags="fivetran_validations", | ||
enabled=var('fivetran_validation_tests_enabled', false) | ||
) }} | ||
|
||
-- this test ensures the github__daily_metrics end model matches the prior version | ||
with prod as ( | ||
select | ||
day, | ||
repository, | ||
sum(coalesce(number_issues_opened, 0)) as number_issues_opened, | ||
sum(coalesce(number_issues_closed, 0)) as number_issues_closed, | ||
sum(coalesce(sum_days_issue_open, 0)) as sum_days_issue_open, | ||
sum(coalesce(longest_days_issue_open, 0)) as longest_days_issue_open, | ||
sum(coalesce(number_prs_opened, 0)) as number_prs_opened, | ||
sum(coalesce(number_prs_merged, 0)) as number_prs_merged, | ||
sum(coalesce(number_prs_closed_without_merge, 0)) as number_prs_closed_without_merge, | ||
sum(coalesce(sum_days_pr_open, 0)) as sum_days_pr_open, | ||
sum(coalesce(longest_days_pr_open, 0)) as longest_days_pr_open | ||
|
||
from {{ target.schema }}_github_prod.github__daily_metrics | ||
where date(day) < current_date() -- BQ | ||
group by 1, 2 | ||
), | ||
|
||
dev as ( | ||
select | ||
day, | ||
repository, | ||
sum(coalesce(number_issues_opened, 0)) as number_issues_opened, | ||
sum(coalesce(number_issues_closed, 0)) as number_issues_closed, | ||
sum(coalesce(sum_days_issue_open, 0)) as sum_days_issue_open, | ||
sum(coalesce(longest_days_issue_open, 0)) as longest_days_issue_open, | ||
sum(coalesce(number_prs_opened, 0)) as number_prs_opened, | ||
sum(coalesce(number_prs_merged, 0)) as number_prs_merged, | ||
sum(coalesce(number_prs_closed_without_merge, 0)) as number_prs_closed_without_merge, | ||
sum(coalesce(sum_days_pr_open, 0)) as sum_days_pr_open, | ||
sum(coalesce(longest_days_pr_open, 0)) as longest_days_pr_open | ||
|
||
from {{ target.schema }}_github_dev.github__daily_metrics | ||
where date(day) < current_date() -- BQ | ||
group by 1, 2 | ||
), | ||
|
||
final as ( | ||
select | ||
coalesce(prod.day, dev.day) as day, | ||
prod.number_issues_opened as prod_number_issues_opened, | ||
dev.number_issues_opened as dev_number_issues_opened, | ||
prod.number_issues_closed as prod_number_issues_closed, | ||
dev.number_issues_closed as dev_number_issues_closed, | ||
prod.sum_days_issue_open as prod_sum_days_issue_open, | ||
dev.sum_days_issue_open as dev_sum_days_issue_open, | ||
prod.longest_days_issue_open as prod_longest_days_issue_open, | ||
dev.longest_days_issue_open as dev_longest_days_issue_open, | ||
prod.number_prs_opened as prod_number_prs_opened, | ||
dev.number_prs_opened as dev_number_prs_opened, | ||
prod.number_prs_merged as prod_number_prs_merged, | ||
dev.number_prs_merged as dev_number_prs_merged, | ||
prod.number_prs_closed_without_merge as prod_number_prs_closed_without_merge, | ||
dev.number_prs_closed_without_merge as dev_number_prs_closed_without_merge, | ||
prod.sum_days_pr_open as prod_sum_days_pr_open, | ||
dev.sum_days_pr_open as dev_sum_days_pr_open, | ||
prod.longest_days_pr_open as prod_longest_days_pr_open, | ||
dev.longest_days_pr_open as dev_longest_days_pr_open | ||
from prod | ||
full outer join dev | ||
on dev.repository = prod.repository | ||
and dev.day = prod.day | ||
) | ||
|
||
select * | ||
from final | ||
where | ||
abs(prod_number_issues_opened - dev_number_issues_opened) >= .01 | ||
or abs(prod_number_issues_closed - dev_number_issues_closed) >= .01 | ||
or abs(prod_sum_days_issue_open - dev_sum_days_issue_open) >= .01 | ||
or abs(prod_longest_days_issue_open - dev_longest_days_issue_open) >= .01 | ||
or abs(prod_number_prs_opened - dev_number_prs_opened) >= .01 | ||
or abs(prod_number_prs_merged - dev_number_prs_merged) >= .01 | ||
or abs(prod_number_prs_closed_without_merge - dev_number_prs_closed_without_merge) >= .01 | ||
or abs(prod_sum_days_pr_open - dev_sum_days_pr_open) >= .01 | ||
or abs(prod_longest_days_pr_open - dev_longest_days_pr_open) >= .01 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
{{ config( | ||
tags="fivetran_validations", | ||
enabled=var('fivetran_validation_tests_enabled', false) | ||
) }} | ||
|
||
-- this test ensures the github__monthly_metrics end model matches the prior version | ||
with prod as ( | ||
select | ||
month, | ||
repository, | ||
sum(coalesce(number_issues_opened, 0)) as number_issues_opened, | ||
sum(coalesce(number_issues_closed, 0)) as number_issues_closed, | ||
sum(coalesce(avg_days_issue_open, 0)) as avg_days_issue_open, | ||
sum(coalesce(longest_days_issue_open, 0)) as longest_days_issue_open, | ||
sum(coalesce(number_prs_opened, 0)) as number_prs_opened, | ||
sum(coalesce(number_prs_merged, 0)) as number_prs_merged, | ||
sum(coalesce(number_prs_closed_without_merge, 0)) as number_prs_closed_without_merge, | ||
sum(coalesce(avg_days_pr_open, 0)) as avg_days_pr_open, | ||
sum(coalesce(longest_days_pr_open, 0)) as longest_days_pr_open | ||
|
||
from {{ target.schema }}_github_prod.github__monthly_metrics | ||
where date(month) < current_date() -- BQ | ||
group by 1, 2 | ||
), | ||
|
||
dev as ( | ||
select | ||
month, | ||
repository, | ||
sum(coalesce(number_issues_opened, 0)) as number_issues_opened, | ||
sum(coalesce(number_issues_closed, 0)) as number_issues_closed, | ||
sum(coalesce(avg_days_issue_open, 0)) as avg_days_issue_open, | ||
sum(coalesce(longest_days_issue_open, 0)) as longest_days_issue_open, | ||
sum(coalesce(number_prs_opened, 0)) as number_prs_opened, | ||
sum(coalesce(number_prs_merged, 0)) as number_prs_merged, | ||
sum(coalesce(number_prs_closed_without_merge, 0)) as number_prs_closed_without_merge, | ||
sum(coalesce(avg_days_pr_open, 0)) as avg_days_pr_open, | ||
sum(coalesce(longest_days_pr_open, 0)) as longest_days_pr_open | ||
|
||
from {{ target.schema }}_github_dev.github__monthly_metrics | ||
where date(month) < current_date() -- BQ | ||
group by 1, 2 | ||
), | ||
|
||
final as ( | ||
select | ||
coalesce(prod.month, dev.month) as month, | ||
prod.number_issues_opened as prod_number_issues_opened, | ||
dev.number_issues_opened as dev_number_issues_opened, | ||
prod.number_issues_closed as prod_number_issues_closed, | ||
dev.number_issues_closed as dev_number_issues_closed, | ||
prod.avg_days_issue_open as prod_avg_days_issue_open, | ||
dev.avg_days_issue_open as dev_avg_days_issue_open, | ||
prod.longest_days_issue_open as prod_longest_days_issue_open, | ||
dev.longest_days_issue_open as dev_longest_days_issue_open, | ||
prod.number_prs_opened as prod_number_prs_opened, | ||
dev.number_prs_opened as dev_number_prs_opened, | ||
prod.number_prs_merged as prod_number_prs_merged, | ||
dev.number_prs_merged as dev_number_prs_merged, | ||
prod.number_prs_closed_without_merge as prod_number_prs_closed_without_merge, | ||
dev.number_prs_closed_without_merge as dev_number_prs_closed_without_merge, | ||
prod.avg_days_pr_open as prod_avg_days_pr_open, | ||
dev.avg_days_pr_open as dev_avg_days_pr_open, | ||
prod.longest_days_pr_open as prod_longest_days_pr_open, | ||
dev.longest_days_pr_open as dev_longest_days_pr_open | ||
from prod | ||
full outer join dev | ||
on dev.repository = prod.repository | ||
and dev.month = prod.month | ||
) | ||
|
||
select * | ||
from final | ||
where | ||
abs(prod_number_issues_opened - dev_number_issues_opened) >= .01 | ||
or abs(prod_number_issues_closed - dev_number_issues_closed) >= .01 | ||
or abs(prod_avg_days_issue_open - dev_avg_days_issue_open) >= .01 | ||
or abs(prod_longest_days_issue_open - dev_longest_days_issue_open) >= .01 | ||
or abs(prod_number_prs_opened - dev_number_prs_opened) >= .01 | ||
or abs(prod_number_prs_merged - dev_number_prs_merged) >= .01 | ||
or abs(prod_number_prs_closed_without_merge - dev_number_prs_closed_without_merge) >= .01 | ||
or abs(prod_avg_days_pr_open - dev_avg_days_pr_open) >= .01 | ||
or abs(prod_longest_days_pr_open - dev_longest_days_pr_open) >= .01 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update line 84 with the similar tables not being synced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep updated!