Add disabling variables for `issue_assignee`, `issue_label`, `label`, and `requested_reviewer_history` #64

fivetran-jamie · 2025-06-30T17:50:32Z

PR Overview

Package version introduced in this PR:
v0.9.1

This PR addresses the following Issue/Feature(s):

T-975175
[Documentation] Move badges below H1 heading #59

Summary of changes:

Creates new variables to disable the issue_assignee, issue_label, label, and requested_reviewer_history models if needed. Appropriately creates null fields or totally excludes fields/joins if the tables are missing.

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
  Consistency tests added for all models, passing

Testing Instructions: Confirm the change addresses the issue(s)

I'll share more detailed screenshots in Height, but without configuring the variables (default value = True) dbt run produces 43 models

With the variables set to False, dbt run produces 32 models

8 of these are from the staging layer, as highlighted in the source PR
The remaining 3 are int_github__issue_assignees, int_github__issue_labels, and int_github__issue_label_joined
- Focus Areas: Complex logic or queries that need extra attention

Changelog

Draft changelog for PR
Final changelog for release review

fivetran-joemarkiewicz

A few comments and requests before approval

fivetran-joemarkiewicz · 2025-06-30T20:47:04Z

models/intermediate/int_github__issue_joined.sql

  creator.login_name as creator_login_name,
  creator.name as creator_name,
  creator.company as creator_company,
+
+  {%- if var('github__using_requested_reviewer_history', True) -%}


I know it's a bit out of scope of this task, but can you please add the fully qualified name of these fields. Some fields have the fully qualified name (eg. issue_assignees.assignees) whereas others do not (hours_request_review_to_first_review). It makes it difficult to trace back where these fields are coming from.

No need to make this update across all the files, but for the ones being updated please make this update to make it easier to maintain in the future.

fivetran-joemarkiewicz · 2025-06-30T20:50:03Z

models/intermediate/int_github__issue_joined.sql

  hours_request_review_to_first_review,
  hours_request_review_to_first_action,
  hours_request_review_to_merge,


For fields like this that are no longer going to persist to the end model if the variables are disabled, we should updated the documentation accordingly to highlight that these fields will only be present with certain variables enabled.

Updated and regenerated docs

fivetran-joemarkiewicz

LGTM

fivetran-joemarkiewicz · 2025-07-01T19:12:03Z

packages.yml

+# - package: fivetran/github_source
+#   version: [">=0.9.0", "<0.10.0"]
+- git: https://github.com/fivetran/dbt_github_source.git
+  revision: feature/add-more-table-vars


Reminder to swap before merge

fivetran-avinash · 2025-07-02T00:16:28Z

.buildkite/scripts/run_models.sh

@@ -18,9 +18,9 @@ cd integration_tests
 dbt deps
 dbt seed --target "$db" --full-refresh
 dbt source freshness --target "$db" || echo "...Only verifying freshness runs…"
+dbt run --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false}' --target "$db" --full-refresh


Suggested change

dbt run --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false}' --target "$db" --full-refresh

dbt run --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false, github__using_label: false}' --target "$db" --full-refresh

Great catch -- updated myself directly

fivetran-avinash · 2025-07-02T00:16:37Z

.buildkite/scripts/run_models.sh

@@ -18,9 +18,9 @@ cd integration_tests
 dbt deps
 dbt seed --target "$db" --full-refresh
 dbt source freshness --target "$db" || echo "...Only verifying freshness runs…"
+dbt run --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false}' --target "$db" --full-refresh
+dbt test --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false}' --target "$db"


Suggested change

dbt test --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false}' --target "$db"

dbt test --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false, github__using_label: false}' --target "$db"

Updated myself directly

fivetran-avinash · 2025-07-02T00:19:27Z

README.md

+    github__using_issue_assignee: false # by default this is assumed to be true
+    github__using_issue_label: false # by default this is assumed to be true
+    github__using_label: false # by default this is assumed to be true
+    github__using_requested_reviewer_history: false # by default this is assumed to be true


Should we update line 84 with the similar tables not being synced?

Yep updated!

fivetran-avinash

@fivetran-jamie Few comments before approval

fivetran-avinash

@fivetran-jamie Approved!

working

9ff05ae

fivetran-jamie changed the title ~~working~~ Add disabling variables for issue_assignee, issue_label, label, and requested_reviewer_history Jun 30, 2025

tests

0a23b4a

fivetran-jamie self-assigned this Jun 30, 2025

fivetran-jamie marked this pull request as ready for review June 30, 2025 19:41

fivetran-jamie added 2 commits June 30, 2025 15:47

tweaks

21d949d

docs

dc60ff2

fivetran-jamie requested a review from fivetran-joemarkiewicz June 30, 2025 19:55

fivetran-joemarkiewicz requested changes Jun 30, 2025

View reviewed changes

joe feedback

66b9759

fivetran-joemarkiewicz approved these changes Jul 1, 2025

View reviewed changes

fivetran-avinash reviewed Jul 2, 2025

View reviewed changes

avinash feedback

0108885

fivetran-avinash approved these changes Jul 2, 2025

View reviewed changes

switch source package dep

ee6eeca

fivetran-jamie merged commit f68f209 into main Jul 2, 2025
9 checks passed

	dbt run --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false}' --target "$db" --full-refresh
	dbt run --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false, github__using_label: false}' --target "$db" --full-refresh

	dbt test --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false}' --target "$db"
	dbt test --vars '{github__using_repo_team: false, github__using_issue_assignee: false, github__using_issue_label: false, github__using_requested_reviewer_history: false, github__using_label: false}' --target "$db"

Add disabling variables for issue_assignee, issue_label, label, and requested_reviewer_history #64

Add disabling variables for issue_assignee, issue_label, label, and requested_reviewer_history #64

Uh oh!

Conversation

fivetran-jamie commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Overview

Submission Checklist

Changelog

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Add disabling variables for `issue_assignee`, `issue_label`, `label`, and `requested_reviewer_history` #64

Add disabling variables for `issue_assignee`, `issue_label`, `label`, and `requested_reviewer_history` #64

fivetran-jamie commented Jun 30, 2025 •

edited

Loading