+
Skip to content

update int_github__pull_request_times to not drop pull requests witho… #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

samkessaram
Copy link
Contributor

…ut requested_reviewers

Please provide your name and company
Sam Kessaram
Zensurance

Link the issue/feature request which this PR is meant to address
#56

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
Updated a join type in int_github__pull_request_times so as to not drop pull requests that did not have explicit reviewers requested.

How did you validate the changes introduced within this PR?

  • dbt tests passed in my company project
  • QA query to validate that merged PRs in my company all now have valid merged_at values

Which warehouse did you use to develop these changes?
Snowflake

Did you update the CHANGELOG?

  • Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Typically there are additional maintenance changes required before this will be ready for an upcoming release. Are you comfortable with the Fivetran team making a few commits directly to your branch?

  • Yes
  • No

If you had to summarize this PR in an emoji, which would it be?

🍔

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

@fivetran-avinash fivetran-avinash changed the base branch from main to release/v0.8.1 October 22, 2024 16:03
@fivetran-avinash fivetran-avinash merged commit 2c1c0ec into fivetran:release/v0.8.1 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载