Release/v0.7.0 #45
Release/v0.7.0 #45
Conversation
Fix #41 Signed-off-by: Alex Co <alex.tuan@mindvalley.com>
Support repository name in the transformed metrics
Customer/add repo cols
bug/reviewers-dedupe
There was a problem hiding this comment.
Hey @fivetran-catfritz ! PR looks good to me, I just added a note for you to update the packages.yml before merging and releasing. But approving!
I did have a question for you - there's really no right or wrong answer. I noticed that in all the models (at least the ones you've updated here) that they all have an order by clause. I know this was already something that existed in this package before you worked on it for this PR, but I was wondering if that clause is necessary 🤔 For small data sets, this doesn't make too large of a difference but for larger sets it may. Perhaps this is something we should discuss at the end of the next standup.
packages.yml
Outdated
| # - package: fivetran/github_source | ||
| # version: [">=0.6.0", "<0.7.0"] | ||
| - git: https://github.com/fivetran/dbt_github_source.git |
There was a problem hiding this comment.
reminder to remove this and bump up the github source version
|
Interesting point! The ORDER BYs don't appear to be necessary, but I really don't know the history, so I agree it would be good to discuss with the team. |
Are you a current Fivetran customer?
Fivetran PR
What change(s) does this PR introduce?
🚨 Breaking Change 🚨
Updated the following models to aggregate at the repository grain in addition to their time period grain. (#42, #43)
github__daily_metrics
github__weekly_metrics
github__monthly_metrics
github__quarterly_metrics
🎉 Features
Added column requested_reviewers to provide a list of users that were requested to review on a pull request. This is to supplement the column reviewers, which provides a list of users that have submitted a reivew, weather or not they were requested to.
PostgreSQL compatibility!
🔧 Bug Fix
Updated model int_github__pull_request_reviewers so that the list of reviewers generated does not contain duplicate usernames.
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
✨
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.