+
Skip to content

bug/reviewers-dedupe #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Feb 1, 2023

Are you a current Fivetran customer?

Fivetran PR

What change(s) does this PR introduce?

🎉 Features

  • Added column requested_reviewers to provide a list of users that were requested to review on a pull request. This is to supplement the column reviewers, which provides a list of users that have submitted a reivew, weather or not they were requested to.
  • PostgreSQL compatibility!

🔧 Bug Fix

  • Updated model int_github__pull_request_reviewers so that the list of reviewers generated does not contain duplicate usernames.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes (will update on release branch)

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • Buildkite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🐥

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-catfritz fivetran-catfritz merged commit 528b9d2 into release/v0.7.0 Feb 2, 2023
@fivetran-catfritz fivetran-catfritz mentioned this pull request Feb 2, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载