Do not trigger transforms when searching in the stack chart #4387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 88.56% // Head: 88.56% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4387 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 282 282
Lines 25333 25333
Branches 6817 6817
=======================================
Hits 22435 22435
Misses 2696 2696
Partials 202 202
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gregtatum
approved these changes
Dec 20, 2022
heh thanks for the approval :) I'm writing a small test around searching in the stack chart but will land then! |
|
Actually the new test is better in #2957, so I'll just land this one! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STR:
Expected: no transform should happen.
Actual: a transform is applied.
production
deploy preview