+
Skip to content

fixed #738: consolidated stats into stat tests #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2019
Merged

fixed #738: consolidated stats into stat tests #743

merged 2 commits into from
Feb 23, 2019

Conversation

oleksii-polovyi
Copy link
Contributor

For some reason we have both https://github.com/filerjs/filer/blob/master/tests/spec/fs.stats.spec.js and https://github.com/filerjs/filer/blob/master/tests/spec/fs.stat.spec.js. We should probably just have https://github.com/filerjs/filer/blob/master/tests/spec/fs.stat.spec.js, since there is no stats method.

Let's move the stats tests into stat, and make sure we aren't duplicating any tests.

  • Consolidated stats into stat tests
  • Ensured that there aren't any duplicating tests

@codecov-io
Copy link

codecov-io commented Feb 22, 2019 •
edited
Loading

Codecov Report

Merging #743 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #743   +/-   ##
======================================
  Coverage    86.6%   86.6%           
======================================
  Files          16      16           
  Lines        1739    1739           
======================================
  Hits         1506    1506           
  Misses        233     233

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d10d64...378896c. Read the comment docs.

humphd
humphd approved these changes Feb 23, 2019
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks again.

@humphd humphd merged commit 2a4fa0f into filerjs:master Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@humphd humphd humphd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oleksii-polovyi @codecov-io @humphd
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载