issue-685 fix: replaced "var" with "let" in fs.unlink.spec.js #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
=========================================
- Coverage 86.71% 86.6% -0.12%
=========================================
Files 16 16
Lines 1746 1739 -7
=========================================
- Hits 1514 1506 -8
- Misses 232 233 +1
Continue to review full report at Codecov.
|
humphd
requested changes
Feb 5, 2019
There was a problem hiding this comment.
This is looking good. Can you change all your uses of let fsPromises = util.fs().promises; and let fs = util.fs(); to use const instead of let? The variables don't change at all in their scope.
Once you do that, and push again, let me know and I'll re-review.
humphd
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue-685.