Add FFI::Enum#size #383
Open
Add FFI::Enum#size #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows enums to be used directly in calls to FFI::MemoryPointer.new. While you still can't get the enum back out, you're at least future-proofing your code against the (admittedly small) possibility that the type of your enums may change in the future (and FFI adds support for that, such as via
|
Thanks for the PR. This makes the most sense coupled with #321. Which is waiting the same functionality to be added to JRuby before I merge it. I'll set up a PR for this in JRuby and take a look into getting the enum into the memory pointer as well when i get a change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows enums to be used directly in calls to FFI::MemoryPointer.new.
While you still can't get the enum back out, you're at least future-proofing
your code against the (admittedly small) possibility that the type of your
enums may change in the future (and FFI adds support for that, such as via