unmaximize: use window's current screen for positioning #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving a maximized window between pages or screens, FVWM records the previous geometry of the unmaximized window, so it can restore correctly. However, this doesn't work well when the maximized window itself has moved between screens or different pages, since the unmaximized geometry from the point of view of the maximized window is now incorrect. Subsequently, unmaximizing a window will put that window in to the ether. For now, the approach is to make unmaximizing a window imply MoveToScreen (relative to the window's screen) such that it remains visible, and should largely do what the user expects. Fixes #68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving a maximized window between pages or screens, FVWM records
the previous geometry of the unmaximized window, so it can restore
correctly.
However, this doesn't work well when the maximized window itself has
moved between screens or different pages, since the unmaximized geometry
from the point of view of the maximized window is now incorrect.
Subsequently, unmaximizing a window will put that window in to the
ether.
For now, the approach is to make unmaximizing a window imply
MoveToScreen (relative to the window's screen) such that it remains
visible, and should largely do what the user expects.
Fixes #68