fix broken positions when drawing 3d borders #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code always skips the top-right point and bottom-right point when drawing the border. This is almost invisible if the background colour is similar to hi and sh colour. However, when the background colour is very different from hi or sh (for example, flat borders), then borders appear to be corrupted. It also underflows when a is 1, in y+i+l-a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code always skips the top-right point and bottom-right
point when drawing the border. This is almost invisible if the
background colour is similar to hi and sh colour. However, when the
background colour is very different from hi or sh (for example, flat
borders), then borders appear to be corrupted.
It also underflows when a is 1, in
y+i+l-a.