Add github-compare #140
Merged
Add github-compare #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhaulagiri
commented
Feb 12, 2018
| } | ||
| }); | ||
|
|
||
| test('finding a comparison without authorization', function (assert) { |
There was a problem hiding this comment.
for consistency i included separate tests for authed/not authed but in general I'm not sure how useful constantly testing this difference. It seems like we could test this once at the adapter level or something and get rid of all of this from the acceptance tests as they aren't really testing that auth is working in any meaningful way unless I'm missing something
There was a problem hiding this comment.
Yea I don't have any strong preference on the auth/non-auth stuff.
3600431 to
1f94ee6
Compare
1f94ee6 to
ad142c7
Compare
This was referenced Feb 12, 2018
Open
ad142c7 to
6627578
Compare
6627578 to
4a6a547
Compare
4a6a547 to
70805e7
Compare
|
This should be good to go now |
elwayman02
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to compare two commits:
this.get('store').queryRecord('github-compare', { repo: 'jimmay5469/old-hash', base: '1234', head: '5678' });API docs