rename user property on github-release to author #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better matches what the api calls this
Dhaulagiri
commented
Feb 12, 2018
| user: belongsTo('github-user', { inverse: null }), | ||
| author: belongsTo('github-user', { inverse: null }), | ||
| user: computed(function() { | ||
| deprecate('The user property on the github-release model has been deprecated. Please use the author property.', false, { id: 'ember-data-github.release-author', until: '1.0.0' }); |
There was a problem hiding this comment.
@elwayman02 I had a thought that we could do something like this for renaming these properties in a backwards compatible way. If you like this I could go back and do this for those other props I renamed as well. Or we can just move forward knowing we have some minor breaking changes.
There was a problem hiding this comment.
Yea this seems like a fine way to being able to release these changes in advance. Then for v1.0 we can remove the backwards-compatible stuff.
There was a problem hiding this comment.
Perfect, I'll make another PR this week to re-add the properties I removed and deprecate them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better matches what the api calls this
Fixes #113