add tests for github-pull #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yea I would actually classify this as a bugfix since it wasn't working before. I doubt anyone is using it if it was broken. :P |
|
I would agree. It seems as though the initial implementation might not have been tried in the wild?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115
Note that technically this is a breaking change but I'm not sure that looking up pull requests would have worked before. The way the adapter was setup would create a request like this which is not actually valid:
https://api.github.com/pulls?pullId=1&repo=user1%2Frepository1Now it will do:
https://api.github.com/repos/user1/repository1/pulls/1