+
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: elkanamol/sierra_status
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.4
Choose a base ref
...
head repository: elkanamol/sierra_status
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.5
Choose a head ref
  • 10 commits
  • 7 files changed
  • 2 contributors

Commits on Sep 8, 2024

  1. refactor(sierra_status): improve code structure and add advanced tests

    - Move AT command constants to a new conf.py file
    - Enhance error handling and input validation in send_at_command function
    - Add type hints and improve docstrings for better code readability
    - Implement more robust logging with formatted output
    - Create advanced test cases for edge cases and error scenarios
    - Refactor existing tests to accommodate new changes
    - Update default values and file naming patterns for consistency
    elkanamol committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    1b85653 View commit details
    Browse the repository at this point in the history
  2. refactor(tests): improve test structure and coverage for USB handle m…

    …odule
    
    - Consolidate redundant test cases for AT commands
    - Enhance test coverage for animate_spinner function
    - Improve error handling and edge case testing
    - Remove commented-out test cases
    - Add type hints to mock objects in test functions
    - Use context managers for patching in some test cases
    - Remove unnecessary empty lines between test classes
    elkanamol committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    5ef9ff1 View commit details
    Browse the repository at this point in the history
  3. feat(ci): add Black code formatter and enable linting

    - Add Black to the pip install command alongside flake8
    - Uncomment and update the linting step to use Black for code style checking
    - Replace flake8 linting with Black's --check option
    
    This change enhances the CI pipeline by introducing code formatting checks,
    ensuring consistent code style across the project.
    elkanamol committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    5e5820f View commit details
    Browse the repository at this point in the history
  4. style(formatting): apply black code formatter across project

    - Apply consistent formatting to setup.py, cli.py, usb_handle.py, and test_usb_handle.py
    - Improve code readability by breaking long lines and adjusting indentation
    - Remove unnecessary blank lines and add spacing where needed
    - Standardize string quotes (use double quotes consistently)
    - Adjust import order in some files
    
    This commit improves code consistency and adheres to PEP 8 style guidelines,
    making the codebase more maintainable and easier to read.
    elkanamol committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    276718e View commit details
    Browse the repository at this point in the history
  5. 8 using external file (#10)

    * refactor(sierra_status): improve code structure and add advanced tests
    
    - Move AT command constants to a new conf.py file
    - Enhance error handling and input validation in send_at_command function
    - Add type hints and improve docstrings for better code readability
    - Implement more robust logging with formatted output
    - Create advanced test cases for edge cases and error scenarios
    - Refactor existing tests to accommodate new changes
    - Update default values and file naming patterns for consistency
    
    * refactor(tests): improve test structure and coverage for USB handle module
    
    - Consolidate redundant test cases for AT commands
    - Enhance test coverage for animate_spinner function
    - Improve error handling and edge case testing
    - Remove commented-out test cases
    - Add type hints to mock objects in test functions
    - Use context managers for patching in some test cases
    - Remove unnecessary empty lines between test classes
    
    * feat(ci): add Black code formatter and enable linting
    
    - Add Black to the pip install command alongside flake8
    - Uncomment and update the linting step to use Black for code style checking
    - Replace flake8 linting with Black's --check option
    
    This change enhances the CI pipeline by introducing code formatting checks,
    ensuring consistent code style across the project.
    
    * style(formatting): apply black code formatter across project
    
    - Apply consistent formatting to setup.py, cli.py, usb_handle.py, and test_usb_handle.py
    - Improve code readability by breaking long lines and adjusting indentation
    - Remove unnecessary blank lines and add spacing where needed
    - Standardize string quotes (use double quotes consistently)
    - Adjust import order in some files
    
    This commit improves code consistency and adheres to PEP 8 style guidelines,
    making the codebase more maintainable and easier to read.
    
    * feat(usb_handle): enhance status logging and timing information
    
    - Add start and finish timestamps to status output
    - Include total script execution time in log
    - Import 'log' function from math module (unused in this change)
    
    This commit improves the diagnostic information provided by the
    status retrieval process, making it easier to track when operations
    started and completed, as well as the overall runtime of the script.
    
    * feat(usb_handle): enhance status logging and timing information
    
    - Add start and finish timestamps to status output
    - Include total script execution time in log
    - Import 'log' function from math module (unused in this change)
    
    This commit improves the diagnostic information provided by the
    status retrieval process, making it easier to track when operations
    started and completed, as well as the overall runtime of the script.
    
    * refactor(usb_handle): improve logging and documentation
    
    - Remove timestamp from initial result string in get_module_status()
    - Add detailed docstring for creat_status_file() function
    - Enhance start_process() function with improved documentation and logging
    - Move start time logging from result string to logging.info() call
    
    This commit improves code readability and maintainability by enhancing
    documentation and refining the logging approach.
    
    * refactor(usb_handle): simplify timestamp formatting in creat_status_file function
    
    - Replace separate time.strftime() call with reuse of existing time_stamp variable
    - Improve code readability and reduce redundancy in result string formatting
    - Ensure consistent timestamp format throughout the status file creation process
    
    * update linting issue
    
    * refactor(usb_handle): improve timestamp handling and code organization
    
    - Move timestamp generation to start_process function
    - Add timestamp to result string before creating status file
    - Remove unnecessary blank lines
    - Update test case to reflect new timestamp handling
    elkanamol authored Sep 8, 2024
    Configuration menu
    Copy the full SHA
    1accdc5 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. feat(cli): add interactive mode flag for custom AT commands

    Add -i/--interactive flag to enable users to send custom AT commands in interactive mode.
    This enhances the CLI flexibility by allowing direct AT command input during runtime.
    elkanamol committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    11d6494 View commit details
    Browse the repository at this point in the history
  2. feat(usb_handle): add interactive AT command mode

    Add new functionality to support interactive AT command sessions:
    - Implement get_interactive_command() for user input validation
    - Add handle_interactive_session() to manage interactive command flow
    - Update start_process() to support both batch and interactive modes
    - Add interactive flag parameter to control execution mode
    
    This enhancement allows users to manually enter and execute AT commands
    in an interactive session while maintaining the existing batch mode functionality.
    elkanamol committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4961dcf View commit details
    Browse the repository at this point in the history
  3. feat(tests): add test coverage for interactive mode functionality

    Add comprehensive test suite for interactive AT command mode including:
    - Test cases for get_interactive_command() with valid/invalid inputs
    - Coverage for handle_interactive_session() with command sequences
    - Tests for start_process() in both interactive and standard modes
    - Validation of command processing and status file creation
    
    This enhances test coverage for the interactive CLI features and ensures
    proper handling of user input scenarios.
    elkanamol committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e0e7f2c View commit details
    Browse the repository at this point in the history
  4. feat: add interactive mode parameter to main function

    - Pass interactive flag to core function in cli.py
    - Bump version from 0.1.4 to 0.1.5
    elkanamol committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e4d9c01 View commit details
    Browse the repository at this point in the history
  5. style: improve code formatting and test readability

    - Add consistent trailing commas in function parameters
    - Fix string quote style in test files (single -> double quotes)
    - Improve readability of long function calls by breaking into multiple lines
    - Format CLI argument definitions consistently
    - Clean up whitespace in docstrings and function signatures
    
    The changes focus on code style consistency across the codebase,
    particularly in sierra_status/src and tests directories.
    elkanamol committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d2009ab View commit details
    Browse the repository at this point in the history
Loading
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载