refactor: use custom eslint config + prettier instead of airbnb config #2520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2520 +/- ##
==========================================
- Coverage 72.89% 72.71% -0.19%
==========================================
Files 91 91
Lines 2365 2349 -16
Branches 448 429 -19
==========================================
- Hits 1724 1708 -16
Misses 471 471
Partials 170 170
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Switch from the airbnb eslint config to one that should be more in line with the rest of the Electron tooling that doesn't use StandardJS.
Please note that
prettieris configured to use single quotes instead of double quotes. This is mostly because I didn't want an even larger diff.Added some test scripts to individual modules to run tests in isolation.
While fixing TypeScript types, I fixed a bug in the Forge 5 ➡️ Forge 6 upgrader that used the wrong key name for make targets.