feat: webFrameMain.fromFrameToken #47850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dsanders11
approved these changes
Jul 22, 2025
10 tasks
erickzhao
reviewed
Jul 24, 2025
this will be updated in another pr
itsananderson
approved these changes
Jul 31, 2025
|
|
||
| interface WebFrameBinding { | ||
| mainFrame: InternalWebFrame; | ||
| WebFrame: Electron.WebFrame; |
There was a problem hiding this comment.
For my own understanding, why is this needed?
There was a problem hiding this comment.
I accidentally included it in this PR, but it was meant for the follow up PR #47717
|
Release Notes Persisted
|
|
/trop run backport-to 38-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I have automatically backported this PR to "38-x-y", please check out #47942 |
3 tasks
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
* feat: webFrameMain.fromFrameToken * refactor: return null instead of undefined * docs: mention renderer webFrame property * chore: undo null->undefined in wfm.fromId api this will be updated in another pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow up to #47616
Adds
webFrameMain.fromFrameToken(processId, frameToken)which should be the defacto method of looking up frames based on the current chromium architecture.Checklist
npm testpassesRelease Notes
Notes: Added
webFrameMain.fromFrameToken(processId, frameToken)to get aWebFrameMaininstance from its frame token.