feat: ServiceWorkerMain.scriptURL #45863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The behavior of these APIs when accessing them after the |
|
@samuelmaddock is this still good to merge? Just doing a courtesy checkin before hitting "Squash and merge" it looks like this was stuck in the review stage for a couple weeks 😅 sorry I missed this one |
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds
scriptURLproperty toServiceWorkerMain. This is equivalent to thescriptURLproperty available in renderers.This was omitted initially as it wasn't available on a public interface. I've since landed a CL to move it to the public
ServiceWorkerVersionBaseInfostruct.https://chromium-review.googlesource.com/c/chromium/src/+/6243058
Checklist
npm testpassesRelease Notes
Notes: Added
scriptURLproperty toServiceWorkerMain.