feat: promisify dialog.showSaveDialog() #17054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebase on #17050 once it's merged. |
3f7d228 to
c9dba0b
Compare
ef2d87c to
088fae3
Compare
|
Review in #16973 (review) also applies here. |
f4ac326 to
8c9d837
Compare
e2855cd to
063fd5e
Compare
miniak
requested changes
Mar 4, 2019
miniak
requested changes
Mar 4, 2019
miniak
requested changes
Mar 4, 2019
fa9b40b to
fe0fa2d
Compare
zcbenz
approved these changes
Mar 5, 2019
miniak
requested changes
Mar 5, 2019
miniak
requested changes
Mar 5, 2019
7960f88 to
c2c9e68
Compare
miniak
requested changes
Mar 5, 2019
miniak
approved these changes
Mar 5, 2019
|
Release Notes Persisted
|
|
On Windows (I don't know in other platforms), the variable I'm not if report this issue in a new bug @miniak @codebytere , I don't have a repo to test the issue but I printed in my project in console: When I select a filename and click When I click on |
|
I'll handle that! |
4 tasks
deepak1556
added a commit
to microsoft/vscode
that referenced
this pull request
Jun 14, 2019
briandk
added a commit
to briandk/transcriptase
that referenced
this pull request
Sep 23, 2019
Electron v. 6.0 introduced a sort-of breaking change: dialog functions now return promises by default. They used to take a callback function. The breaking change means there are now explicitly synchronous versions of dialog methods—in this case: showMessageBoxSync. Refs electron/electron#17054
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Promisifies
dialog.showSaveDialog().cc @ckerr @MarshallOfSound @deepak1556
Checklist
npm testpassesRelease Notes
Notes: Split
dialog.showSaveDialog()into a synchronous version and a version that returns a Promise