+
Skip to content

feat: promisify netLog.stopLogging() #16862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2019
Merged

feat: promisify netLog.stopLogging() #16862

merged 1 commit into from
Feb 19, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Feb 9, 2019 •
edited
Loading

Description of Change

This PR promisifies netLog.stopLogging()

Depends on #16935

/cc @codebytere

Checklist

Release Notes

Notes: Converted netLog.stopLogging() to return a Promise instead of taking a callback.

@miniak miniak requested review from codebytere and a team February 9, 2019 23:02
@miniak miniak force-pushed the miniak/promisify-netlog branch 2 times, most recently from a0285f0 to ba62322 Compare February 9, 2019 23:17
@miniak miniak self-assigned this Feb 9, 2019
@miniak miniak force-pushed the miniak/promisify-netlog branch from ba62322 to 8352b46 Compare February 9, 2019 23:45
codebytere
codebytere reviewed Feb 13, 2019
View reviewed changes
@miniak miniak force-pushed the miniak/promisify-netlog branch 2 times, most recently from 3196558 to 0730e60 Compare February 14, 2019 17:09
jkleinsc
jkleinsc requested changes Feb 15, 2019
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for a small doc change.

@miniak miniak force-pushed the miniak/promisify-netlog branch from 0730e60 to ce9d63e Compare February 15, 2019 18:19
@jkleinsc
Copy link
Member

Arm CI is failing on this PR for a reason unrelated to this PR. #16992 will resolve that issue.

@miniak
Copy link
Contributor Author

miniak commented Feb 18, 2019

@jkleinsc can you please merge?

@alexeykuzmin alexeykuzmin merged commit 7e7abc2 into master Feb 19, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 19, 2019

Release Notes Persisted

Converted netLog.stopLogging() to return a Promise instead of taking a callback.

@alexeykuzmin alexeykuzmin deleted the miniak/promisify-netlog branch February 19, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniak @jkleinsc @codebytere @alexeykuzmin
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载