+
Skip to content

setup_starpls doesn't work with proxy servers and violates principle of reproducability #79

@NEOatNHNG

Description

@NEOatNHNG

The setup_starpls downloads the binaries via curl in a genrule. This fails when using a proxy server because the genrule runs in a stripped environment (missing the http_proxy environment variables).

The better way would be to separate the download step from the genrule. E.g. by having a http_archive() in the MODULE.bazel or registry and then the genrule would just make it executable and provide it as a target in the module. That way also download will be reproducible because it needs to be downloaded (only) if the hash of the archive changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Draft

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载