Resolve Rails 5 deprecation warnings for *_filter hooks. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails 4.0.0 (2012) DHH renamed the *_filter hooks in AbstractController to *_action. In Rails 5.0 it now prints deprecation warnings for *_filter calls as they will be removed in Rails 5.1.
|
Any chance to merge this and release? Now that Rails 5 is out since a while. Thanks! |
spastorino
reviewed
Dec 22, 2016
| skip_before_filter :verify_authenticity_token | ||
| before_filter :authenticate_mandrill_request!, :only => [:create] | ||
| skip_before_action :verify_authenticity_token | ||
| before_action :authenticate_mandrill_request!, :only => [:create] |
There was a problem hiding this comment.
maybe is better to do something like ...
if respond_to?(:before_action)
skip_before_action :verify_authenticity_token
before_action :authenticate_mandrill_request!, :only => [:create]
else
skip_before_filter :verify_authenticity_token
before_filter :authenticate_mandrill_request!, :only => [:create]
endSo it works in older Rails versions.
There was a problem hiding this comment.
@spastorino I like that idea. I just merged all the rails 5 efforts on master and took the easy way out "1.5.0+ only supports rails 5". If someone would like to try and bring back backwards compatibility, I'd really appreciate that.
| spec.version = Mandrill::Rails::VERSION | ||
|
|
||
| spec.add_runtime_dependency "activesupport", ">= 3.0.3" | ||
| spec.add_runtime_dependency "activesupport", ">= 4.0.0" |
This was referenced May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 4.0.0 (2012) DHH renamed the
*_filterhooks inAbstractControllerto*_action. In Rails 5.0 it now printsdeprecation warnings for
*_filtercalls as they will be removedin Rails 5.1.