Fix version checking #70
Conversation
|
Draft because I need to test this |
There was a problem hiding this comment.
I hoped that phpunit would return a different error code depending on whether the command was unavailable or there was a configuration error, but it didn't.
Ideally, this phpunit version constraint should be set in all the packages that use this action, so there would be no need to check here.
Our downstream projects should prevent the downgrade of PHPUnit to ancient patch releases in their composer.json. We need to check that we're not on PHPUnit 9 though. |
Are you suggesting I should just simplify this to keep the check against 10.5.49? Works for me… |
1ed2223 to
b0ebb0c
Compare
I intended to exclude e.g. 11.5.28 but failed to do so because it is greater than 10.5.49. Let us instead just check against 10.0.0: if the upgrade fails, it should be easy to fix it by requiring the correct patch version.
b0ebb0c to
b41495f
Compare
Yes, both should work fine. |
I intended to exclude e.g. 11.5.28 but failed to do so because it is greater than 10.5.49.
Let us instead just check against 10.0.0: if the upgrade fails, it
should be easy to fix it by requiring the correct patch version.