Remove require #69
Merged
Remove require #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless we specify the working directory, composer will install dependencies for the project in the root directory.
We want developers to be able to able to generate docs as well. This means the docs directory should already contain a composer.json for them to use.
|
To be tagged as a major release, since now it requires the |
derrabus
approved these changes
Oct 12, 2025
paulinevos
approved these changes
Oct 13, 2025
|
Might also be friendly to print a warning if it fails because it's not present? |
|
I think the |
|
There you go, we get a nice error: https://github.com/doctrine/collections/actions/runs/18463790981/job/52600984006?pr=476#step:4:40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof that it works: https://github.com/doctrine/orm/actions/runs/18446312765/job/52553521717?pr=12216