Add RedisProvider #167
Open
Add RedisProvider #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fyko
suggested changes
Oct 21, 2020
Cutty/Pasta
Co-authored-by: Carter <45381083+Fyko@users.noreply.github.com>
16c7814 to
62c102f
Compare
|
If you haven't already, you might want to look into using |
|
@Alcremie I picked the library that appears to be suggested by RedisLabs. Even if it's slightly harder to use, it is likely to work when Redis changes stuff and since our provider is very simple it seemed reasonable. |
|
i need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provider feels a bit complex compared to the other providers in the project. This is partly because I'm supporting multiple use models: with or without in-memory caching and with or without the ReJSON module. Additionally, I must confess it's been a while since I've written JavaScript, so it's possible that the code could be simplified or made to be more idiomatic. I'm very open to suggestions.
I have attempted to include ancillary project assets like docs and linking the provider into
index.jsandindex.d.ts. Again, very open to input/suggestions.Thanks much for considering this contribution.