+
Skip to content

feat(Arguments): remove string types #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

papaia
Copy link
Contributor

@papaia papaia commented Apr 23, 2020

In general, this PR removes the option to have type as a string in the options of an argument.

Details

Code

  • Removed TypeResolver entirely
    • Removed CommandHandler#useListenerHandler, as it just passed the given ListenerHandler to the TypeResolver.
    • Removed CommandHandler#resolver and its references (Arguments)
  • Removed ArgumentTypes constant
  • Added UNKNOWN_MENTION_TYPE error key (self explanatory)
  • Added Types export for all built-in types

Typings

  • Updated for all of the above

Tests

  • Updated according to all of the above
    • Updated all argument types to their respective function in Types export
    • Removed TypeResolver reference
  • Added prime command to test custom types

Docs

  • Moved ArgumentTypeCaster to Types.js
  • Moved ArgumentType to Types.js

Remaining

  • Update docs and guides accordingly
  • Test the changes (Yes, I did some testing myself, but you can never be too sure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载