reset details scroll when different msg chosen #113
Conversation
Summary of ChangesHello @dhth, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a quality-of-life improvement by ensuring that the message details viewport automatically scrolls to the top when a user selects a different message. This prevents the details view from retaining its previous scroll position, which could lead to a confusing user experience. The change also refactors how terminal resize events influence the details view's state, making the logic clearer and more robust. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the logic for updating the message details view to correctly reset the scroll position when a new message is selected. The changes centralize the update logic into the updateMsgDetailsVP function, improving code clarity and maintainability. The variable forceRefreshMsgDetailsVP has been aptly renamed to terminalResized to better reflect its purpose. The core logic change correctly resets the viewport to the top for a new message, while preserving the scroll position during a terminal resize. I have one minor suggestion to simplify a condition for improved readability.
No description provided.