Cleanup container user log message and trivial code #9420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log message is pretty old, but we should keep the information around by stating the user even when it's an empty string. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9420 +/- ##
==========================================
+ Coverage 65.96% 66.65% +0.68%
==========================================
Files 202 202
Lines 27761 27939 +178
==========================================
+ Hits 18312 18622 +310
+ Misses 7904 7739 -165
- Partials 1545 1578 +33 🚀 New features to boost your workflow:
|
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The log message is pretty old, but we should keep the information around by stating the user even when it's an empty string.
Which issue(s) this PR fixes:
Refers to #9416
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?