-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix potential panic when crio fails to parse artifact's ref name. #9407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9407 +/- ##
==========================================
- Coverage 67.28% 67.25% -0.03%
==========================================
Files 202 202
Lines 27758 27760 +2
==========================================
- Hits 18677 18671 -6
- Misses 7531 7536 +5
- Partials 1550 1553 +3 🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitoku, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bitoku do we have to cherry-pick this one? |
@saschagrunert thanks! |
/cherry-pick release-1.33 |
@bitoku: new pull request created: #9408 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes panic when the ref name is invalid although this shouldn't happen in a normal scenario, because the ref is specified based on docker-reference (
<registry>/<image-name>:<tag>
) by cri-o.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?