+
Skip to content

Conversation

bitoku
Copy link
Contributor

@bitoku bitoku commented Aug 15, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes panic when the ref name is invalid although this shouldn't happen in a normal scenario, because the ref is specified based on docker-reference (<registry>/<image-name>:<tag>) by cri-o.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@bitoku bitoku requested a review from mrunalp as a code owner August 15, 2025 14:51
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 15, 2025
@openshift-ci openshift-ci bot requested review from QiWang19 and hasan4791 August 15, 2025 14:51
Signed-off-by: Ayato Tokubi <atokubi@redhat.com>
@bitoku bitoku changed the title Fix potential panic when it fails to parse ref name. Fix potential panic when crio fails to parse artifact's ref name. Aug 15, 2025
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.25%. Comparing base (3d8e440) to head (943329e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9407      +/-   ##
==========================================
- Coverage   67.28%   67.25%   -0.03%     
==========================================
  Files         202      202              
  Lines       27758    27760       +2     
==========================================
- Hits        18677    18671       -6     
- Misses       7531     7536       +5     
- Partials     1550     1553       +3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2025
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitoku, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a9a3887 into cri-o:main Aug 18, 2025
74 of 76 checks passed
@saschagrunert
Copy link
Member

@bitoku do we have to cherry-pick this one?

@bitoku
Copy link
Contributor Author

bitoku commented Aug 18, 2025

@saschagrunert thanks!
I don't think it's necessary, though no reason not to cherry-pick it.

@bitoku
Copy link
Contributor Author

bitoku commented Aug 18, 2025

/cherry-pick release-1.33

@openshift-cherrypick-robot

@bitoku: new pull request created: #9408

In response to this:

/cherry-pick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载