+
Skip to content

Conversation

sohankunkerkar
Copy link
Member

This commit introduces goroutine monitoring to help detect potential deadlocks and goroutine leaks in production environments.

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #9371

Special notes for your reviewer:

Does this PR introduce a user-facing change?

add goroutine monitoring

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 23, 2025
Copy link
Contributor

openshift-ci bot commented Sep 23, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 23, 2025
Copy link
Contributor

openshift-ci bot commented Sep 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2025
@sohankunkerkar sohankunkerkar changed the title *: add goroutine monitoring [WIP] *: add goroutine monitoring Sep 23, 2025
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 16.00000% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.46%. Comparing base (81e69a5) to head (9bc3b8a).
⚠️ Report is 9 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (81e69a5) and HEAD (9bc3b8a). Click for more details.

HEAD has 24 uploads less than BASE
Flag BASE (81e69a5) HEAD (9bc3b8a)
35 11
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9477       +/-   ##
===========================================
- Coverage   67.24%   55.46%   -11.79%     
===========================================
  Files         202      202               
  Lines       28025    28169      +144     
===========================================
- Hits        18845    15623     -3222     
- Misses       7602    10989     +3387     
+ Partials     1578     1557       -21     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This commit introduces goroutine monitoring to help detect potential
deadlocks and goroutine leaks in production environments.

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
It is used to check whether crio had time to sync before shutting down.
If not found, crio wipe will clear the storage directory.

**goroutines_monitor**=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how many goroutines we can say is abnormal.
Last time I checked it was ~30 independent from #pods, but not sure...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFE: goroutine alert

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载