-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[WIP] *: add goroutine monitoring #9477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sohankunkerkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9477 +/- ##
===========================================
- Coverage 67.24% 55.46% -11.79%
===========================================
Files 202 202
Lines 28025 28169 +144
===========================================
- Hits 18845 15623 -3222
- Misses 7602 10989 +3387
+ Partials 1578 1557 -21 🚀 New features to boost your workflow:
|
c73a03f
to
e95258c
Compare
This commit introduces goroutine monitoring to help detect potential deadlocks and goroutine leaks in production environments. Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
e95258c
to
9bc3b8a
Compare
It is used to check whether crio had time to sync before shutting down. | ||
If not found, crio wipe will clear the storage directory. | ||
|
||
**goroutines_monitor**=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how many goroutines we can say is abnormal.
Last time I checked it was ~30 independent from #pods, but not sure...
This commit introduces goroutine monitoring to help detect potential deadlocks and goroutine leaks in production environments.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #9371
Special notes for your reviewer:
Does this PR introduce a user-facing change?