Migrate to container-libs #9460
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3640329 to
78625f8
Compare
|
@cri-o/cri-o-maintainers PTAL |
78625f8 to
82202af
Compare
|
/hold just checking the version of podman we'd need to sync to to do this real quick |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9460 +/- ##
=======================================
Coverage 67.13% 67.13%
=======================================
Files 202 202
Lines 28140 28140
=======================================
+ Hits 18891 18892 +1
+ Misses 7670 7669 -1
Partials 1579 1579 🚀 New features to boost your workflow:
|
82202af to
481613a
Compare
|
Rebased. |
`c/{common,image,storage}` have been migrated to c/container-libs, which
we adapt.
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
481613a to
8504de2
Compare
|
Rebased. Can we get this in now @cri-o/cri-o-maintainers ? |
|
/test ci-cgroupv2-integration |
|
/retest @cri-o/cri-o-maintainers PTAL |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
c/{common,image,storage}have been migrated to c/container-libs, which we adapt.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?