+
Skip to content

[release-1.33] : server: handle missing network namespace gracefully during networkStop #9337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2025
Merged

[release-1.33] : server: handle missing network namespace gracefully during networkStop #9337

merged 4 commits into from
Jul 11, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9301

/assign sohankunkerkar

Handle missing network namespace gracefully during networkStop

@sohankunkerkar
server: handle missing network namespace gracefully during networkStop
8daef88 
After host reboot, network namespaces are destroyed but CRI-O attempts
to clean them up during pod sandbox destruction, causing CNI plugin
failures and preventing pods from restarting properly. The fix ensures
pods can restart normally after host reboots.

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@sohankunkerkar
test: add coverage for network recovery after reboot with destroyed n…
ff0ca8f 
…etns

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@sohankunkerkar
test: use quay.io instead of registry.fedoraproject.org
0ba1262 
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@sohankunkerkar
contrib/test/ci: skip network recovery after reboot test for kata
e3326cb 
Kata VMs use real infra containers that persist in storage, unlike normal
containers that use spoofed infra containers. This fundamental architectural
difference means the 'Network recovery after reboot with destroyed netns'
test scenario doesn't apply to Kata VMs in the same way.

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 11, 2025
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-58229 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [release-1.33] : server: handle missing network namespace gracefully during networkStop

In response to this:

This is an automated cherry-pick of #9301

/assign sohankunkerkar

Handle missing network namespace gracefully during networkStop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 11, 2025
@openshift-ci openshift-ci bot requested review from QiWang19 and hasan4791 July 11, 2025 12:00
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 11, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 11, 2025
@openshift-ci-robot
Copy link

@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-58229, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected Jira Issue OCPBUGS-58229 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-58229 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

/retitle [release-1.33] : server: handle missing network namespace gracefully during networkStop

In response to this:

This is an automated cherry-pick of #9301

/assign sohankunkerkar

Handle missing network namespace gracefully during networkStop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 11, 2025
@openshift-ci openshift-ci bot changed the title [release-1.33] OCPBUGS-58229: server: handle missing network namespace gracefully during networkStop [release-1.33] : server: handle missing network namespace gracefully during networkStop Jul 11, 2025
@openshift-ci-robot openshift-ci-robot removed jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 11, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #9301

/assign sohankunkerkar

Handle missing network namespace gracefully during networkStop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sohankunkerkar
sohankunkerkar approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 12.82051% with 34 lines in your changes missing coverage. Please review.

Project coverage is 47.41%. Comparing base (cb609a5) to head (e3326cb).
Report is 5 commits behind head on release-1.33.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.33    #9337      +/-   ##
================================================
- Coverage         47.46%   47.41%   -0.06%     
================================================
  Files               162      163       +1     
  Lines             24073    24103      +30     
================================================
+ Hits              11427    11428       +1     
- Misses            11528    11555      +27     
- Partials           1118     1120       +2
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot openshift-merge-bot bot merged commit fcb351d into cri-o:release-1.33 Jul 11, 2025
48 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sohankunkerkar sohankunkerkar sohankunkerkar approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@sohankunkerkar sohankunkerkar

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @openshift-ci-robot @sohankunkerkar
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载