+
Skip to content

CRI-O reads its configuration from /etc first and then /usr #9173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

roman-kiselenko
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

The configuration files would be searched and merged from top to bottom:

  1. /etc/crio/crio.conf (file)
  2. /usr/lib/crio/crio.conf (file)
  3. --config (file)
  4. /etc/crio/crio.conf.d/* (dir)
  5. /usr/lib/crio/crio.conf.d/* (dir)
  6. --config-dir (dir)
  7. CLI parameters

Which issue(s) this PR fixes:

Fixes #9075

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

CRI-O reads its configuration from /etc first and then /usr.

The configuration files would be searched and merged from top to bottom:

1. /etc/crio/crio.conf (file)
2. /usr/lib/crio/crio.conf (file)
3. --config (file)
4. /etc/crio/crio.conf.d/* (dir)
5. /usr/lib/crio/crio.conf.d/* (dir)
6. --config-dir  (dir)
7. CLI parameters

The configuration files would be searched and merged from top to bottom:

1. `/etc/crio/crio.conf` (file)
2. `/usr/lib/crio/crio.conf` (file)
3. `--config` (file)
4. `/etc/crio/crio.conf.d/*` (dir)
5. `/usr/lib/crio/crio.conf.d/*` (dir)
6. `--config-dir`  (dir)
7. `CLI` parameters

Signed-off-by: roman-kiselenko <roman.kiselenko.dev@gmail.com>
@roman-kiselenko roman-kiselenko requested a review from mrunalp as a code owner May 1, 2025 19:37
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. labels May 1, 2025
@roman-kiselenko roman-kiselenko changed the title CRI-O reads its configuration from /etc first and then /usr. CRI-O reads its configuration from /etc first and then /usr May 1, 2025
@openshift-ci openshift-ci bot requested review from klihub and littlejawa May 1, 2025 19:37
Copy link
Contributor

openshift-ci bot commented May 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: roman-kiselenko
Once this PR has been reviewed and has the lgtm label, please assign nalind for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roman-kiselenko roman-kiselenko marked this pull request as draft May 1, 2025 19:39
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2025
Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 42.22222% with 26 lines in your changes missing coverage. Please review.

Project coverage is 47.03%. Comparing base (454d8a5) to head (c2a2e18).
Report is 133 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9173      +/-   ##
==========================================
+ Coverage   46.99%   47.03%   +0.03%     
==========================================
  Files         161      161              
  Lines       23661    23710      +49     
==========================================
+ Hits        11120    11152      +32     
- Misses      11440    11452      +12     
- Partials     1101     1106       +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Jun 1, 2025

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 1, 2025
Copy link

github-actions bot commented Jul 3, 2025

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Read configuration from /usr/lib/crio/crio.conf & /usr/lib/crio/crio.conf
1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载