+
Skip to content

Fix comment location about error message #9067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Small follow-up on #9050

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Small follow-up on cri-o#9050

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert requested a review from mrunalp as a code owner March 19, 2025 11:54
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 19, 2025
@openshift-ci openshift-ci bot requested review from hasan4791 and littlejawa March 19, 2025 11:54
Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.26%. Comparing base (bdcf72f) to head (64567e9).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9067      +/-   ##
==========================================
- Coverage   47.26%   47.26%   -0.01%     
==========================================
  Files         159      159              
  Lines       23407    23408       +1     
==========================================
- Hits        11064    11063       -1     
- Misses      11252    11254       +2     
  Partials     1091     1091              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saschagrunert
Copy link
Member Author

/retest

2 similar comments
@saschagrunert
Copy link
Member Author

/retest

@bitoku
Copy link
Contributor

bitoku commented Mar 24, 2025

/retest

@bitoku
Copy link
Contributor

bitoku commented Mar 24, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e137827 into cri-o:main Mar 24, 2025
74 of 78 checks passed
@saschagrunert saschagrunert deleted the comment-location branch March 24, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载