Add image volume subpath support #9050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2598159 to
8a25cbe
Compare
This was referenced Mar 10, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9050 +/- ##
==========================================
- Coverage 47.37% 47.26% -0.12%
==========================================
Files 158 159 +1
Lines 23334 23407 +73
==========================================
+ Hits 11055 11063 +8
- Misses 11190 11253 +63
- Partials 1089 1091 +2 🚀 New features to boost your workflow:
|
61ca9b4 to
1db6562
Compare
giuseppe
reviewed
Mar 11, 2025
f83c27e to
7b2fd10
Compare
4a8d78d to
00c207e
Compare
00c207e to
c2b6478
Compare
|
/retest |
c2b6478 to
6fd363e
Compare
6fd363e to
976c6ba
Compare
|
/retest |
|
/retest @cri-o/cri-o-maintainers PTAL |
|
/retest |
976c6ba to
1f74c5e
Compare
|
@cri-o/cri-o-maintainers PTAL |
giuseppe
reviewed
Mar 18, 2025
1f74c5e to
3a95114
Compare
giuseppe
reviewed
Mar 18, 2025
|
@saschagrunert I've simplified the version in Podman to use OpenInRoot: containers/podman#25617 |
Do we want to make this a helper in c/common or do you prefer having a split-up implementation? |
3a95114 to
952643e
Compare
saschagrunert
commented
Mar 18, 2025
Comment on lines
+822
to
+838
| var cleanupSafeMounts []*safeMountInfo | ||
|
|
||
| runtime.LockOSThread() | ||
|
|
||
| cleanupFunc := func() { | ||
| runtime.UnlockOSThread() | ||
|
|
||
| for _, s := range cleanupSafeMounts { | ||
| s.Close() | ||
| } | ||
| } | ||
|
|
||
| defer func() { | ||
| if err != nil { | ||
| cleanupFunc() | ||
| } | ||
| }() |
There was a problem hiding this comment.
Hm, we may have to do this in scope of CreateContainer() and not createSandboxContainer(). 🤔
Add sub path support to image volumes and extend integration tests for that scenario. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
952643e to
fca4ea6
Compare
|
@giuseppe PTAL again. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
Mar 19, 2025
Small follow-up on cri-o#9050 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add sub path support to image volumes and extend integration tests for that scenario.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Refers to kubernetes/kubernetes#130135
Needs kubernetes-sigs/cri-tools#1793
Does this PR introduce a user-facing change?