+
Skip to content

[release-1.30] OCPBUGS-46026: Revert "Cherry-pick changes from containers/storage project" #8993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

[release-1.30] OCPBUGS-46026: Revert "Cherry-pick changes from containers/storage project" #8993

merged 1 commit into from
Feb 7, 2025

Conversation

PannagaRao
Copy link
Contributor

@PannagaRao PannagaRao commented Feb 6, 2025 •
edited by haircommander
Loading

This reverts commit ee48ae2. The required changes from container/storage are already merged in the previous commit.

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR is to revert the commit that replaced the commit [https://github.com//pull/8828] before it which had the required changes from containers/storage project.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@PannagaRao PannagaRao requested a review from mrunalp as a code owner February 6, 2025 17:36
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Feb 6, 2025
@openshift-ci-robot
Copy link

@PannagaRao: This pull request references Jira Issue OCPBUGS-46026, which is invalid:

  • expected Jira Issue OCPBUGS-46026 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This reverts commit ee48ae2. The required changes from container/storage are already merged in the previous commit.

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR is to revert the commit that replaced the commit [https://github.com//pull/8828] before it which had the required changes from containers/storage project.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Feb 6, 2025
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 6, 2025
@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/bug Categorizes issue or PR as related to a bug. labels Feb 6, 2025
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 6, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

Hi @PannagaRao. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Revert "Cherry-pick changes from containers/storage project"
1250a7e 
This reverts commit ee48ae2.
The required changes from container/storage are already merged in the previous commit.

Signed-off-by: Pannaga Rao Bhoja Ramamanohara
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Feb 6, 2025
@haircommander
Copy link
Member

/approve
/lgtm

thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, PannagaRao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@haircommander
Copy link
Member

/release-note-none

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a0f09c2 into cri-o:release-1.30 Feb 7, 2025
44 of 49 checks passed
@openshift-ci-robot
Copy link

@PannagaRao: Jira Issue OCPBUGS-46026: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-46026 has been moved to the MODIFIED state.

In response to this:

This reverts commit ee48ae2. The required changes from container/storage are already merged in the previous commit.

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR is to revert the commit that replaced the commit [https://github.com//pull/8828] before it which had the required changes from containers/storage project.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sohankunkerkar sohankunkerkar removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PannagaRao @openshift-ci-robot @haircommander @sohankunkerkar
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载