+
Skip to content

[release-1.22] server: filter sysctls passed through CRI if host namespace #5616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2022
Merged

[release-1.22] server: filter sysctls passed through CRI if host namespace #5616

merged 3 commits into from
Feb 17, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #5610

/assign haircommander

Fix a bug where a pod given a host IPC or network namespace could configure sysctls on the host

@haircommander
server: skip sysctls that would affect the host
f38449f 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
test: add test for skipped sysctls
7807f81 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 9, 2022
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 9, 2022
Merged
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Feb 9, 2022
@openshift-ci openshift-ci bot requested review from fidencio and kolyshkin February 9, 2022 19:28
@haircommander
config: add NewSysctl function
a1b6e9a 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander haircommander reopened this Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #5616 (2fdd192) into release-1.22 (7486bc8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 2fdd192 differs from pull request most recent head a1b6e9a. Consider uploading reports for the commit a1b6e9a to get more accurate results

@@               Coverage Diff                @@
##           release-1.22    #5616      +/-   ##
================================================
- Coverage         43.79%   43.78%   -0.02%     
================================================
  Files               120      120              
  Lines             11834    11840       +6     
================================================
+ Hits               5183     5184       +1     
- Misses             6160     6165       +5     
  Partials            491      491

@haircommander
Copy link
Member

/retest
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2022
@haircommander
Copy link
Member

Oh right meant to
/hold
This until it was verified

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 a1b6e9a link false /test e2e_cgroupv2
ci/openshift-jenkins/integration_crun_cgroupv2 a1b6e9a link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b53b319 into cri-o:release-1.22 Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@fidencio fidencio Awaiting requested review from fidencio

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @haircommander @openshift-bot @openshift-merge-robot
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载