Move crio defaults back to /etc/crio/crio.conf #3554
Conversation
cdcbc2f to
84deb07
Compare
Codecov Report
@@ Coverage Diff @@
## master #3554 +/- ##
=======================================
Coverage 43.78% 43.78%
=======================================
Files 101 101
Lines 7751 7751
=======================================
Hits 3394 3394
Misses 4058 4058
Partials 299 299 |
The config default should be in /etc/crio/crio.conf and not in /etc/crio/crio.conf.d/00-defaults.conf. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
|
/retest LGTM PTAL @saschagrunert |
|
@umohnani8: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
FYI @saschagrunert we have talked about maybe having 1.18 deprecate the use of crio.conf, then 1.19 fully use crio.conf.d |
|
LGTM, but would like a head nod from @saschagrunert |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What type of PR is this?
/kind design
What this PR does / why we need it:
The config default should be in /etc/crio/crio.conf and not
in /etc/crio/crio.conf.d/00-defaults.conf.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Signed-off-by: Urvashi Mohnani umohnani@redhat.com