+
Skip to content

Feature/add security scan vulnerability calls #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 24, 2023
Merged

Feature/add security scan vulnerability calls #35

merged 5 commits into from
Apr 24, 2023

Conversation

tbronsonCoveo
Copy link

Problem

Missing Github advanced security attributes and calls

Solution

  • Added attributes to Repository object to include SecurityAndAnalysis values:
    • advanced security status
    • secret scanning status
    • secret scanning push protection status
  • Added get code scanning analyses call to Repository
    • Created CodeScanningAnalysis Object returned from call

Tests are incoming, opening now to get immediate feedback as I try to understand the custom test framework.

@tbronsonCoveo
* Added Security and Analysis to Repository
c42a7c6 
* Created Security And Analysis object
* Created AdvancedSecurity object
* Created SecretScanning object
* Created SecretScanningPushProtection object
@tbronsonCoveo
* Added get code scanning analyses to Repository
9bea2e0 
* Created CodeScanningAnalysis object
@tbronsonCoveo
* Added Repository test for security and analysis
cb8508f 
* Added Repository test for get code scan analyses
* Added CodeScanAnalysis attributes test
@tbronsonCoveo
Copy link
Author

tbronsonCoveo commented Apr 20, 2023 •
edited
Loading

Tests are complete

FYI

  • This repo is pretty far from the original fork
  • I tried applying the linting following the doc but it wanted to change another 15+ files so I didn't commit those
  • The tests are broken locally (for me at least) unless you remove the assertion in Framework.py:176 that validates the header
  • I added tests that cover all but didn't bother adding tests to each small object class since they are already tested in Repository
  • I couldn't get the replay/record feature to work (does it even exist?) so I just copy pasted template queries from Github doc

JPLachance
JPLachance approved these changes Apr 21, 2023
View reviewed changes
Copy link

@JPLachance JPLachance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand of PyGitHub, this looks good to me.

jonapich
jonapich approved these changes Apr 21, 2023
View reviewed changes
Copy link

@jonapich jonapich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tbronsonCoveo
Copy link
Author

@jonapich Donc est-ce qu'on peut merge? Je connais pas la procédure pour tag une release and deploy au pypi coveo.

@jonapich jonapich merged commit 84948fe into master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JPLachance JPLachance JPLachance approved these changes

@jonapich jonapich jonapich approved these changes

@dblanchette dblanchette Awaiting requested review from dblanchette

@pballandras pballandras Awaiting requested review from pballandras

@wtrep wtrep Awaiting requested review from wtrep

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tbronsonCoveo @JPLachance @jonapich
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载