AddInto #256
Merged
AddInto #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adds type Model = AddInto<(Linear<2, 5>, Linear<3, 5>)>;
let model: Model = Default::default();
let _: Tensor1D<5> = model.forward((Tensor1D::<2>::zeros(), Tensor1D::<3>::zeros()));This should help with some types of recurrent networks, as it's now easier to input extra things besides the standard input |
coreylowman
requested changes
Oct 27, 2022
There was a problem hiding this comment.
Looks good so far! Pretty easy to understand the macros too. Can you make the following changes:
- a couple small fixes for ModuleMut (as I suggested in the comments)
- can you add serialization for this into
src/nn/npz_impls.rs? It should be relatively easy since you can just use the sub modules implementation for serialization
|
Alright, will make the changes when I have the time! |
|
for npz saving/loading I can probably just copy the implementation for SplitInto as it's effectively the same struct, just different functionality |
coreylowman
approved these changes
Oct 30, 2022
|
Noice, thanks for making such a cool crate for neural nets! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddInto, to allow easier multiple inputs for networks