Change tensors to use Arc so they implement Send and Sync #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, tensors use Rc to allow cloning the tensor without reallocating the data. However, an Rc is neither Send or Sync, which prevents tensors and everything that contain them (most notably, Modules) from being moved to another thread. For example, it is currently impossible to share a network across threads except via suboptimal workarounds like serializing the network to bytes on one thread and deserializing it on the other. By using Arc, tensors now implement Send and Sync. The cost of using atomic operations should be negligible.
|
Hey thanks for this PR, this is a great minimal diff to look at and really big improvements to thread sharing! 😁 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tensors use
Rcto allow cloning the tensor without reallocating the data. However,Rcis neitherSendorSync, which prevents tensors and everything that contain them (most notably, Modules) from being moved to another thread.For example, it is currently impossible to share a network across threads except via suboptimal workarounds like serializing the network to bytes on one thread and deserializing it on the other.
By using
Arc, tensors now implementSendandSync. The cost of using atomic operations should be negligible.