Run CI for all kind of pushes - not only pull request related ones #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the tests where only run for pull requests - but commits to branches should be tested aswell.
Before the code style was only checked for pull requests - so it would have been possible to commit code that doesn't match the style of the rest of the source code.
Before the commit it would have been possible to commit source code which wouldn't have been checked based on cargo features.
It seems that pull requests don't get triggered by the "push" event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR the GitHub actions where only run for pull requests related pushes.
Therefore there was the possibility for maintainers to sneak in code to the code base which was not tested / checked for code style and checked for cargo features (only if they wouldn't do a pull request and merge branches directly).
It is as well not a very nice developer experience when you need to open a pull request every time you wanna test a change and maybe need to force-push some changes (which get displayed as such in the pull request itself but not in normal branches (before a pull request was created)).
This PR runs the GitHub actions for every kind of push (commits to single branches w/o a pull request as well as commits to pull request related branches (which could also be outside of this repository since GitHub supports this feature of "crossover pull-requests")).
Keep in mind that only the last commit in each push will be tested with GitHub actions as its the default behavior which cannot be changed.