feat: add Tensorlike to clean up spooky ghosts
#689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreylowman
reviewed
Apr 11, 2023
| /// Contains everything that comprises a tensor, except possibly for the actual data. This really | ||
| /// exists to unify handling of [Tensor] and [GhostTensor]. | ||
| /// | ||
| /// *If it looks like a tensor and barks like a tensor, then pet it like a tensor.* |
coreylowman
approved these changes
Apr 11, 2023
|
Nice, thanks for the improvement 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some tensor ops allow using either the Tensor with the
Arcdata reference or aGhostTensorwithout it. Currently it usesResultto do this, but this is a bit awkward. I found that a unifying traitTensorlikeis enough to handle all of the current scenarios and is cleaner.